[
https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104046#comment-13104046
]
Daryn Sharp commented on HADOOP-7602:
-------------------------------------
Yes. Had a lengthy IM, here's what I believe to be the summary:
- We agree that something better than a NPE should thrown on bad input.
-- We disagree on whether it should return empty string (Jitendra), or throw a
more descriptive exception (me).
-- We disagree that removing the exception invites other problems for all other
callers of the method.
-- We disagree that the NPE is better addressed in another bug. Note: I have
fixed this on the service ip->host.
- I think we disagree that har should not be calling
buildDTServiceName/buildDTAuthority.
-- I maintain it should not be called because it's building a Credentials key
for a token. Har does not have tokens so the Credentials key is of no value.
-- Har should just directly return a key instead of passing junk to a method
that should always result in an exception.
I believe the simple solution is to fix the har filesystem with a few lines.
John, Nathan, and I will review the code and post recommendations.
> wordcount, sort etc on har files fails with NPE
> -----------------------------------------------
>
> Key: HADOOP-7602
> URL: https://issues.apache.org/jira/browse/HADOOP-7602
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.205.0, 0.20.206.0
> Reporter: John George
> Assignee: John George
> Fix For: 0.20.205.0
>
> Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch,
> hadoop-7602.3.patch, hadoop-7602.4.patch, hadoop-7602.6.patch,
> hadoop-7602.7.patch, hadoop-7602.8.patch, hadoop-7602.daryns_comment.2.patch,
> hadoop-7602.daryns_comment.patch, hadoop-7602.patch
>
>
> wordcount, sort etc on har files fails with
> NPE@createSocketAddr(NetUtils.java:137).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
