[
https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105050#comment-13105050
]
Nathan Roberts commented on HADOOP-7602:
----------------------------------------
+1 for current patch.
As far as the two options, I'd prefer throwing the IllegalArgumentException
instead of tripping the NPE. This seems cleaner than an NPE and allows us to
catch errors during the setup of the service rather than limping along with a
bogus service name.
The current patch doesn't do this but I'm ok with doing that in a separate jira
since it's not required to fix the problem with HAR.
I think it would be a good idea to file an additional jira to take another look
at the visibility of the security utils and things like getCanonicalService.
Doesn't seem like these should be fully public. Seems like a good activity for
trunk.
> wordcount, sort etc on har files fails with NPE
> -----------------------------------------------
>
> Key: HADOOP-7602
> URL: https://issues.apache.org/jira/browse/HADOOP-7602
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.205.0, 0.20.206.0
> Reporter: John George
> Assignee: John George
> Fix For: 0.20.205.0
>
> Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch,
> hadoop-7602.3.patch, hadoop-7602.4.patch, hadoop-7602.6.patch,
> hadoop-7602.7.patch, hadoop-7602.8.patch, hadoop-7602.9.patch,
> hadoop-7602.daryns_comment.2.patch, hadoop-7602.daryns_comment.patch,
> hadoop-7602.patch
>
>
> wordcount, sort etc on har files fails with
> NPE@createSocketAddr(NetUtils.java:137).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
