snvijaya commented on a change in pull request #2072:
URL: https://github.com/apache/hadoop/pull/2072#discussion_r445355225
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -378,6 +428,7 @@ private synchronized void
flushWrittenBytesToService(boolean isClose) throws IOE
flushWrittenBytesToServiceInternal(position, false, isClose);
}
+
Review comment:
unnecessary additional new line.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java
##########
@@ -47,6 +47,7 @@
// Default upload and download buffer size
public static final int DEFAULT_WRITE_BUFFER_SIZE = 8 * ONE_MB; // 8 MB
+ public static final int APPENDBLOB_MAX_WRITE_BUFFER_SIZE = 4 * ONE_MB; // 8
MB
Review comment:
Minor. Fix comment.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java
##########
@@ -337,7 +344,6 @@ public void processResponse(final byte[] buffer, final int
offset, final int len
if (this.isTraceEnabled) {
startTime = System.nanoTime();
}
-
Review comment:
Undo. newline needed after a block.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java
##########
@@ -185,13 +189,18 @@ void execute() throws AzureBlobFileSystemException {
try {
LOG.debug("Retrying REST operation {}. RetryCount = {}",
operationType, retryCount);
+
Review comment:
remove newline
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java
##########
@@ -185,13 +189,18 @@ void execute() throws AzureBlobFileSystemException {
try {
LOG.debug("Retrying REST operation {}. RetryCount = {}",
operationType, retryCount);
+
Thread.sleep(client.getRetryPolicy().getRetryInterval(retryCount));
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
if (result.getStatusCode() >= HttpURLConnection.HTTP_BAD_REQUEST) {
+ if (this.isAppendBlobAppend && retryCount > 0 &&
result.getStorageErrorCode().equals("InvalidQueryParameterValue")) {
Review comment:
Why is it that for Http Status code 400 and above, exception is
suppressed ? Can you please add code comments for the reason.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -430,10 +487,15 @@ private synchronized void shrinkWriteOperationQueue()
throws IOException {
}
private void waitForTaskToComplete() throws IOException {
+
Review comment:
remove newline
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -367,7 +418,6 @@ private synchronized void
flushWrittenBytesToService(boolean isClose) throws IOE
throw new FileNotFoundException(ex.getMessage());
}
}
-
Review comment:
Undo. new line needed.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -389,6 +440,12 @@ private synchronized void
flushWrittenBytesToServiceAsync() throws IOException {
private synchronized void flushWrittenBytesToServiceInternal(final long
offset,
final boolean retainUncommitedData, final boolean isClose) throws
IOException {
+
Review comment:
remove newline
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -272,7 +272,8 @@ public AbfsRestOperation deleteFilesystem() throws
AzureBlobFileSystemException
}
public AbfsRestOperation createPath(final String path, final boolean isFile,
final boolean overwrite,
- final String permission, final String
umask) throws AzureBlobFileSystemException {
+ final String permission, final String
umask,
+ final boolean appendBlob) throws
AzureBlobFileSystemException {
Review comment:
Minor. boolean flag better named as isAppendBlob
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
