snvijaya commented on a change in pull request #2072:
URL: https://github.com/apache/hadoop/pull/2072#discussion_r446094945
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java
##########
@@ -185,13 +189,18 @@ void execute() throws AzureBlobFileSystemException {
try {
LOG.debug("Retrying REST operation {}. RetryCount = {}",
operationType, retryCount);
+
Thread.sleep(client.getRetryPolicy().getRetryInterval(retryCount));
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
if (result.getStatusCode() >= HttpURLConnection.HTTP_BAD_REQUEST) {
+ if (this.isAppendBlobAppend && retryCount > 0 &&
result.getStorageErrorCode().equals("InvalidQueryParameterValue")) {
Review comment:
This isnt the right place to handle a case specific to appendblob.
HttpOperation returned to specific AbfsClient method can take the call on what
to return. Similar is done for rename.
You can check:
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java#L358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
