amahussein commented on a change in pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#discussion_r553003268
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
##########
@@ -1414,21 +1414,20 @@ protected void sendStopSignal() {
}
int waitCount = 0;
LOG.info("Waiting for Client to exit loop");
- while (!isRunning.get()) {
+ while (isRunning.get()) {
try {
Thread.sleep(50);
} catch (InterruptedException ie) {
// do nothing
} finally {
- waitCount++;
- if (isRunning.get() || waitCount > 2000) {
+ if (++waitCount > 2000) {
break;
}
}
}
- LOG.info("Stopping yarnClient within the Client");
+ LOG.info("Stopping yarnClient within the DS Client");
yarnClient.stop();
- yarnClient.waitForServiceToStop(clientTimeout);
+ //yarnClient.waitForServiceToStop(clientTimeout);
Review comment:
Oh! I forgot to delete that line.
Waiting for the service to stop is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
