amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755797255
> > @goiri the code changes fix {{testDSShellWithEnforceExecutionType}}.
> > The problem with the test was that it launches two containers executing
cmd `date`. Apparently the two containers would exit fast. The unit test will
stay blocked waiting for the containers to be exactly "2".
> > This does not take into consideration that the containers count is 3
including the AMContainer.
> > The fix was to get rid of the equality in the check, and change the
application command to `ls`
>
> That makes sense, does it make sense to make the assert more general than
an equality instead of getting rid of the equality?
In `DistributedShellBaseTest.waitForContainersLaunch()`, I used inequality
`if (containers.size() < nContainers) { return false; }`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
