touchida commented on a change in pull request #2585:
URL: https://github.com/apache/hadoop/pull/2585#discussion_r596818639
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedBlockReconstructor.java
##########
@@ -126,12 +128,26 @@ private void reconstructTargets(int toReconstructLen)
throws IOException {
int[] erasedIndices = stripedWriter.getRealTargetIndices();
ByteBuffer[] outputs =
stripedWriter.getRealTargetBuffers(toReconstructLen);
+ if (isValidationEnabled()) {
+ markBuffers(inputs);
+ decode(inputs, erasedIndices, outputs);
+ resetBuffers(inputs);
+
+ DataNodeFaultInjector.get().badDecoding(outputs);
+ getValidator().validate(inputs, erasedIndices, outputs);
Review comment:
@runitao
Thanks for your comment!
How about adding a metric for the exception like
`EcInvalidReconstructionTasks`? (I saw your deleted comment.)
As for logging, I think it's better to output more messages through the
entire EC reconstruction process, and so I'd like to handle it in another issue.
Are you suggesting anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
