bogthe commented on a change in pull request #3260:
URL: https://github.com/apache/hadoop/pull/3260#discussion_r684160558
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -822,10 +854,21 @@ private void bindAWSClient(URI name, boolean dtEnabled)
throws IOException {
S3_CLIENT_FACTORY_IMPL, DEFAULT_S3_CLIENT_FACTORY_IMPL,
S3ClientFactory.class);
+ // If there's no endpoint set, then use the default for bucket or
AccessPoint. Overriding is
+ // useful when using FIPS or DualStack S3 endpoints.
+ String endpoint = conf.getTrimmed(ENDPOINT, "");
+ if (endpoint.isEmpty()) {
Review comment:
No, what I initially intended is to say "if you're not setting the
endpoint then I'll provide a default Access Point endpoint". This is because I
don't know what endpoint the user wants to point it to.
This is also why your tests are failing when you set the endpoint to
`ap-south-1`. I'm open to adding another `fs.s3a.accesspoint-endpoint`
configuration if it's better to provide an option to override only the access
point endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
