mehakmeet commented on a change in pull request #3260:
URL: https://github.com/apache/hadoop/pull/3260#discussion_r684173504
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java
##########
@@ -1507,4 +1507,13 @@ public static void skipIfKmsKeyIdIsNotSet(Configuration
configuration) {
}
}
+ /**
+ * Skip if a test doesn't use CSE.
+ */
+ public static void skipIfCSEIsNotEnabled(Configuration configuration) {
+ String encryption =
configuration.get(Constants.SERVER_SIDE_ENCRYPTION_ALGORITHM, "");
+ if (!encryption.equals(S3AEncryptionMethods.CSE_KMS.getMethod())) {
Review comment:
The tests that require this are SSE tests which shouldn't skip if
CSE-KMS is the encryption method used. It should've been skipped if CSE-KMS is
enabled, to tell the user that SSE-KMS is not the method used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
