ayushtkn commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-916167736
I am quite convinced with having a formatter checked in to the code. Mostly, if it can take care of import ordering. With a exception that we keep the shaded guava imports at the same place as we would have kept, if it was a normal guava import to keep backporting easy(I was told to do so in one PR) I think I missed the thread on common-dev, If others are ok, then it should be fine. What is the source of these xmls, you have written them? If yes, we need someone who can decode this as well, Which I am certainly not :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
