virajjasani edited a comment on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-916183454
> What is the source of these xmls, you have written them? Not exactly, these are generated from IDE only, so we are good. I have also reimported them to re-verify the behaviour :) And yes, import related checkstyle warnings are also taken care of with this formatter. However, if we want to change import order for thirdparty shaded guava, I believe we can first do it on checkstyle.xml and then update formatter accordingly. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
