szilard-nemeth commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r708495101
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueuePreemption.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.hadoop.yarn.conf.YarnConfiguration; + +public class AbstractCSQueuePreemption { + private final boolean preemptionDisabled; + // Indicates if the in-queue preemption setting is ever disabled within the + // hierarchy of this queue. + private final boolean intraQueuePreemptionDisabledInHierarchy; + + public AbstractCSQueuePreemption( + CSQueue queue, + CapacitySchedulerContext csContext, + CapacitySchedulerConfiguration configuration) { + this.preemptionDisabled = isQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + this.intraQueuePreemptionDisabledInHierarchy = + isIntraQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + } + + /** + * The specified queue is cross-queue preemptable if system-wide cross-queue + * preemption is turned on unless any queue in the <em>qPath</em> hierarchy + * has explicitly turned cross-queue preemption off. + * NOTE: Cross-queue preemptability is inherited from a queue's parent. + * + * @param q queue to check preemption state + * @param csContext + * @param configuration capacity scheduler config + * @return true if queue has cross-queue preemption disabled, false otherwise + */ + private boolean isQueueHierarchyPreemptionDisabled(CSQueue q, Review comment: Actually, there are some useful comments for both methods. I would do this in a followup if you really want to simplify this more :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
