brumi1024 commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r709176304
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueuePreemption.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.hadoop.yarn.conf.YarnConfiguration; + +public class AbstractCSQueuePreemption { + private final boolean preemptionDisabled; + // Indicates if the in-queue preemption setting is ever disabled within the + // hierarchy of this queue. + private final boolean intraQueuePreemptionDisabledInHierarchy; + + public AbstractCSQueuePreemption( + CSQueue queue, + CapacitySchedulerContext csContext, + CapacitySchedulerConfiguration configuration) { + this.preemptionDisabled = isQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + this.intraQueuePreemptionDisabledInHierarchy = + isIntraQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + } + + /** + * The specified queue is cross-queue preemptable if system-wide cross-queue + * preemption is turned on unless any queue in the <em>qPath</em> hierarchy + * has explicitly turned cross-queue preemption off. + * NOTE: Cross-queue preemptability is inherited from a queue's parent. + * + * @param q queue to check preemption state + * @param csContext + * @param configuration capacity scheduler config + * @return true if queue has cross-queue preemption disabled, false otherwise + */ + private boolean isQueueHierarchyPreemptionDisabled(CSQueue q, + CapacitySchedulerContext csContext, CapacitySchedulerConfiguration configuration) { + boolean systemWidePreemption = + csContext.getConfiguration() + .getBoolean(YarnConfiguration.RM_SCHEDULER_ENABLE_MONITORS, + YarnConfiguration.DEFAULT_RM_SCHEDULER_ENABLE_MONITORS); + CSQueue parentQ = q.getParent(); + + // If the system-wide preemption switch is turned off, all of the queues in + // the qPath hierarchy have preemption disabled, so return true. + if (!systemWidePreemption) return true; + + // If q is the root queue and the system-wide preemption switch is turned + // on, then q does not have preemption disabled (default=false, below) + // unless the preemption_disabled property is explicitly set. + if (parentQ == null) { + return configuration.getPreemptionDisabled(q.getQueuePath(), false); + } + + // If this is not the root queue, inherit the default value for the + // preemption_disabled property from the parent. Preemptability will be + // inherited from the parent's hierarchy unless explicitly overridden at + // this level. + return configuration.getPreemptionDisabled(q.getQueuePath(), + parentQ.getPreemptionDisabled()); + } + + /** + * The specified queue is intra-queue preemptable if + * 1) system-wide intra-queue preemption is turned on + * 2) no queue in the <em>qPath</em> hierarchy has explicitly turned off intra + * queue preemption. + * NOTE: Intra-queue preemptability is inherited from a queue's parent. + * + * @param q queue to check intra-queue preemption state + * @param csContext + * @param configuration capacity scheduler config + * @return true if queue has intra-queue preemption disabled, false otherwise + */ + private boolean isIntraQueueHierarchyPreemptionDisabled(CSQueue q, + CapacitySchedulerContext csContext, CapacitySchedulerConfiguration configuration) { + boolean systemWideIntraQueuePreemption = + csContext.getConfiguration().getBoolean( Review comment: Valid point. Let's leave it here in this patch, since there is another jira for removing the csContext usages. ########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueuePreemption.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.hadoop.yarn.conf.YarnConfiguration; + +public class AbstractCSQueuePreemption { + private final boolean preemptionDisabled; + // Indicates if the in-queue preemption setting is ever disabled within the + // hierarchy of this queue. + private final boolean intraQueuePreemptionDisabledInHierarchy; + + public AbstractCSQueuePreemption( + CSQueue queue, + CapacitySchedulerContext csContext, + CapacitySchedulerConfiguration configuration) { + this.preemptionDisabled = isQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + this.intraQueuePreemptionDisabledInHierarchy = + isIntraQueueHierarchyPreemptionDisabled(queue, csContext, configuration); + } + + /** + * The specified queue is cross-queue preemptable if system-wide cross-queue + * preemption is turned on unless any queue in the <em>qPath</em> hierarchy + * has explicitly turned cross-queue preemption off. + * NOTE: Cross-queue preemptability is inherited from a queue's parent. + * + * @param q queue to check preemption state + * @param csContext + * @param configuration capacity scheduler config + * @return true if queue has cross-queue preemption disabled, false otherwise + */ + private boolean isQueueHierarchyPreemptionDisabled(CSQueue q, Review comment: OK, resolving this comment thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
