steveloughran commented on code in PR #4537:
URL: https://github.com/apache/hadoop/pull/4537#discussion_r917289045
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/util/PlatformName.java:
##########
@@ -45,9 +45,34 @@ public class PlatformName {
/**
* A public static variable to indicate the current java vendor is
- * IBM java or not.
+ * IBM and the type is Java Technology Edition which provides its
+ * own implementations of many security packages and Cipher suites.
+ * Note that these are not provided in Semeru runtimes:
+ * See https://developer.ibm.com/languages/java/semeru-runtimes/
*/
- public static final boolean IBM_JAVA = JAVA_VENDOR_NAME.contains("IBM");
+ public static final boolean USE_IBM_JAVA_PACKAGES = shouldUseIbmPackages();
+
+ /*
+ * IBM_JAVA must be preserved due to the public nature of the property.
+ */
+ @Deprecated
+ public static final boolean IBM_JAVA = USE_IBM_JAVA_PACKAGES;
Review Comment:
can't you just leave this as is and so not need to change so many other
files?
##########
hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java:
##########
@@ -38,8 +38,19 @@
import java.util.Arrays;
public class TestMiniKdc extends KerberosSecurityTestcase {
- private static final boolean IBM_JAVA = System.getProperty("java.vendor")
- .contains("IBM");
+ private static final boolean USE_IBM_JAVA_PACKAGES = shouldUseIbmPackages();
Review Comment:
should just use PlatformNames
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
