steveloughran commented on code in PR #4537:
URL: https://github.com/apache/hadoop/pull/4537#discussion_r917813067
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/util/PlatformName.java:
##########
@@ -45,9 +45,28 @@ public class PlatformName {
/**
* A public static variable to indicate the current java vendor is
- * IBM java or not.
+ * IBM and the type is Java Technology Edition which provides its
+ * own implementations of many security packages and Cipher suites.
+ * Note that these are not provided in Semeru runtimes:
+ * See https://developer.ibm.com/languages/java/semeru-runtimes/
*/
- public static final boolean IBM_JAVA = JAVA_VENDOR_NAME.contains("IBM");
+ public static final boolean IBM_JAVA = shouldUseIbmPackages();
+
+ private static boolean shouldUseIbmPackages() {
+ if (JAVA_VENDOR_NAME.contains("IBM")) {
+ try {
+ /**
+ * This class is provided by all supported IBM JTE Runtimes,
+ * but ensures we do not make assumptions of existence of
+ * specialised security modules based on vendor alone.
Review Comment:
minor nit; you've' used the uk spelling. i'm happy with this, but don't want
to confuse others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
