goiri commented on code in PR #4711:
URL: https://github.com/apache/hadoop/pull/4711#discussion_r941830630
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -312,4 +324,45 @@ public Version loadVersion() {
return null;
}
+ @Override
+ public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
+ AddReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId =
+ request.getReservationHomeSubCluster().getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ reservations.put(reservationId,
+ request.getReservationHomeSubCluster().getHomeSubCluster());
+ }
+ return
AddReservationHomeSubClusterResponse.newInstance(reservations.get(reservationId));
+ }
+
+ @Override
+ public GetReservationHomeSubClusterResponse getReservationHomeSubCluster(
+ GetReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId = request.getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ throw new YarnException("Reservation " + reservationId + " does not
exist");
+ }
+ SubClusterId subClusterId = reservations.get(reservationId);
+ return GetReservationHomeSubClusterResponse.newInstance(
+ ReservationHomeSubCluster.newInstance(reservationId, subClusterId));
+ }
+
+ @Override
+ public GetReservationsHomeSubClusterResponse getReservationsHomeSubCluster(
+ GetReservationsHomeSubClusterRequest request) throws YarnException {
+ List<ReservationHomeSubCluster> result = new ArrayList<>();
+
+ for (Entry<ReservationId, SubClusterId> entry : reservations.entrySet()) {
+ ReservationId key = entry.getKey();
+ SubClusterId value = entry.getValue();
+ ReservationHomeSubCluster homeSubCluster =
Review Comment:
Single line
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -312,4 +324,45 @@ public Version loadVersion() {
return null;
}
+ @Override
+ public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
+ AddReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId =
+ request.getReservationHomeSubCluster().getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ reservations.put(reservationId,
+ request.getReservationHomeSubCluster().getHomeSubCluster());
+ }
+ return
AddReservationHomeSubClusterResponse.newInstance(reservations.get(reservationId));
+ }
+
+ @Override
+ public GetReservationHomeSubClusterResponse getReservationHomeSubCluster(
+ GetReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId = request.getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ throw new YarnException("Reservation " + reservationId + " does not
exist");
+ }
+ SubClusterId subClusterId = reservations.get(reservationId);
+ return GetReservationHomeSubClusterResponse.newInstance(
+ ReservationHomeSubCluster.newInstance(reservationId, subClusterId));
+ }
+
+ @Override
+ public GetReservationsHomeSubClusterResponse getReservationsHomeSubCluster(
+ GetReservationsHomeSubClusterRequest request) throws YarnException {
+ List<ReservationHomeSubCluster> result = new ArrayList<>();
+
+ for (Entry<ReservationId, SubClusterId> entry : reservations.entrySet()) {
+ ReservationId key = entry.getKey();
Review Comment:
better names than key/value; reservationId, subclusterId
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -312,4 +324,45 @@ public Version loadVersion() {
return null;
}
+ @Override
+ public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
+ AddReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId =
Review Comment:
Single line
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -312,4 +324,45 @@ public Version loadVersion() {
return null;
}
+ @Override
+ public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
+ AddReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId =
+ request.getReservationHomeSubCluster().getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ reservations.put(reservationId,
+ request.getReservationHomeSubCluster().getHomeSubCluster());
Review Comment:
Extract
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/policies/router/BaseRouterPoliciesTest.java:
##########
@@ -126,4 +136,62 @@ public void testNullReservationContext() throws Exception {
() -> policy.getReservationHomeSubcluster(null));
}
+ @Test
+ public void testUnknownReservation() throws Exception {
+
+ long now = Time.now();
+ ReservationSubmissionRequest resReq = getReservationSubmissionRequest();
+ ReservationId reservationId = ReservationId.newInstance(now, 1);
+ when(resReq.getQueue()).thenReturn("queue1");
+ when(resReq.getReservationId()).thenReturn(reservationId);
+
+ // route an application that uses this app
+ ApplicationSubmissionContext applicationSubmissionContext =
+ ApplicationSubmissionContext.newInstance(
+ ApplicationId.newInstance(now, 1), "app1", "queue1",
Priority.newInstance(1),
+ null, false, false, 1, null, null, false);
+
+ applicationSubmissionContext.setReservationID(resReq.getReservationId());
+ FederationRouterPolicy policy = (FederationRouterPolicy) getPolicy();
+
+ LambdaTestUtils.intercept(YarnException.class,
+ "Reservation " + reservationId + " does not exist",
+ () -> policy.getHomeSubcluster(applicationSubmissionContext, new
ArrayList<>()));
+ }
+
+ @Test
+ public void testFollowReservation() throws YarnException {
+
+ long now = Time.now();
+ ReservationSubmissionRequest resReq = getReservationSubmissionRequest();
+ when(resReq.getQueue()).thenReturn("queue1");
+ when(resReq.getReservationId())
Review Comment:
Single line
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ReservationHomeSubCluster.java:
##########
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.yarn.server.federation.store.records;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceAudience.Public;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.yarn.api.records.ReservationId;
+import org.apache.hadoop.yarn.util.Records;
+
+/**
+ * <p>
+ * ReservationHomeSubCluster is a report of the runtime information of the
+ * reservation that is running in the federated cluster.
+ *
+ * <p>
+ * It includes information such as:
+ * <ul>
+ * <li>{@link ReservationId}</li>
+ * <li>{@link SubClusterId}</li>
+ * </ul>
+ *
+ */
+@Private
+@Unstable
+public abstract class ReservationHomeSubCluster {
+
+ @Private
+ @Unstable
+ public static ReservationHomeSubCluster newInstance(ReservationId appId,
+ SubClusterId homeSubCluster) {
+ ReservationHomeSubCluster appMapping =
Review Comment:
Single line.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -312,4 +324,45 @@ public Version loadVersion() {
return null;
}
+ @Override
+ public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
+ AddReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId =
+ request.getReservationHomeSubCluster().getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ reservations.put(reservationId,
+ request.getReservationHomeSubCluster().getHomeSubCluster());
+ }
+ return
AddReservationHomeSubClusterResponse.newInstance(reservations.get(reservationId));
+ }
+
+ @Override
+ public GetReservationHomeSubClusterResponse getReservationHomeSubCluster(
+ GetReservationHomeSubClusterRequest request) throws YarnException {
+ FederationReservationHomeSubClusterStoreInputValidator.validate(request);
+ ReservationId reservationId = request.getReservationId();
+ if (!reservations.containsKey(reservationId)) {
+ throw new YarnException("Reservation " + reservationId + " does not
exist");
+ }
+ SubClusterId subClusterId = reservations.get(reservationId);
+ return GetReservationHomeSubClusterResponse.newInstance(
+ ReservationHomeSubCluster.newInstance(reservationId, subClusterId));
Review Comment:
Extract.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/ReservationHomeSubClusterPBImpl.java:
##########
@@ -0,0 +1,167 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.yarn.server.federation.store.records.impl.pb;
+
+import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.yarn.api.records.ReservationId;
+import org.apache.hadoop.yarn.api.records.impl.pb.ReservationIdPBImpl;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProto;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProtoOrBuilder;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.SubClusterIdProto;
+import org.apache.hadoop.yarn.proto.YarnProtos.ReservationIdProto;
+import
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
+
+import org.apache.hadoop.thirdparty.protobuf.TextFormat;
+
+/**
+ * Protocol buffer based implementation of {@link ReservationHomeSubCluster}.
+ */
+@Private
+@Unstable
+public class ReservationHomeSubClusterPBImpl extends ReservationHomeSubCluster
{
+
+ private ReservationHomeSubClusterProto proto =
+ ReservationHomeSubClusterProto.getDefaultInstance();
+ private ReservationHomeSubClusterProto.Builder builder = null;
+ private boolean viaProto = false;
+
+ private ReservationId reservationId = null;
+ private SubClusterId homeSubCluster = null;
+
+ public ReservationHomeSubClusterPBImpl() {
+ builder = ReservationHomeSubClusterProto.newBuilder();
+ }
+
+ public ReservationHomeSubClusterPBImpl(ReservationHomeSubClusterProto proto)
{
+ this.proto = proto;
+ viaProto = true;
+ }
+
+ public ReservationHomeSubClusterProto getProto() {
+ mergeLocalToProto();
+ proto = viaProto ? proto : builder.build();
+ viaProto = true;
+ return proto;
+ }
+
+ private void mergeLocalToProto() {
+ if (viaProto) {
+ maybeInitBuilder();
+ }
+ mergeLocalToBuilder();
+ proto = builder.build();
+ viaProto = true;
+ }
+
+ private void maybeInitBuilder() {
+ if (viaProto || builder == null) {
+ builder = ReservationHomeSubClusterProto.newBuilder(proto);
+ }
+ viaProto = false;
+ }
+
+ private void mergeLocalToBuilder() {
+ if (this.reservationId != null) {
+ builder.setReservationId(convertToProtoFormat(this.reservationId));
+ }
+ if (this.homeSubCluster != null) {
+ builder.setHomeSubCluster(convertToProtoFormat(this.homeSubCluster));
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return getProto().hashCode();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == null) {
+ return false;
+ }
+ if (other.getClass().isAssignableFrom(this.getClass())) {
+ return this.getProto().equals(this.getClass().cast(other).getProto());
+ }
+ return false;
+ }
+
+ @Override
+ public String toString() {
+ return TextFormat.shortDebugString(getProto());
+ }
+
+ @Override
+ public ReservationId getReservationId() {
+ ReservationHomeSubClusterProtoOrBuilder p = viaProto ? proto : builder;
+ if (!p.hasReservationId()) {
+ return null;
+ }
+ this.reservationId = convertFromProtoFormat(p.getReservationId());
+ return reservationId;
Review Comment:
return this.reservationId
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/ReservationHomeSubClusterPBImpl.java:
##########
@@ -0,0 +1,167 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.yarn.server.federation.store.records.impl.pb;
+
+import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.yarn.api.records.ReservationId;
+import org.apache.hadoop.yarn.api.records.impl.pb.ReservationIdPBImpl;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProto;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProtoOrBuilder;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.SubClusterIdProto;
+import org.apache.hadoop.yarn.proto.YarnProtos.ReservationIdProto;
+import
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
+
+import org.apache.hadoop.thirdparty.protobuf.TextFormat;
+
+/**
+ * Protocol buffer based implementation of {@link ReservationHomeSubCluster}.
+ */
+@Private
+@Unstable
+public class ReservationHomeSubClusterPBImpl extends ReservationHomeSubCluster
{
+
+ private ReservationHomeSubClusterProto proto =
+ ReservationHomeSubClusterProto.getDefaultInstance();
+ private ReservationHomeSubClusterProto.Builder builder = null;
+ private boolean viaProto = false;
+
+ private ReservationId reservationId = null;
+ private SubClusterId homeSubCluster = null;
+
+ public ReservationHomeSubClusterPBImpl() {
+ builder = ReservationHomeSubClusterProto.newBuilder();
+ }
+
+ public ReservationHomeSubClusterPBImpl(ReservationHomeSubClusterProto proto)
{
+ this.proto = proto;
+ viaProto = true;
+ }
+
+ public ReservationHomeSubClusterProto getProto() {
+ mergeLocalToProto();
+ proto = viaProto ? proto : builder.build();
+ viaProto = true;
+ return proto;
+ }
+
+ private void mergeLocalToProto() {
+ if (viaProto) {
+ maybeInitBuilder();
+ }
+ mergeLocalToBuilder();
+ proto = builder.build();
+ viaProto = true;
+ }
+
+ private void maybeInitBuilder() {
+ if (viaProto || builder == null) {
+ builder = ReservationHomeSubClusterProto.newBuilder(proto);
+ }
+ viaProto = false;
+ }
+
+ private void mergeLocalToBuilder() {
+ if (this.reservationId != null) {
+ builder.setReservationId(convertToProtoFormat(this.reservationId));
+ }
+ if (this.homeSubCluster != null) {
+ builder.setHomeSubCluster(convertToProtoFormat(this.homeSubCluster));
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return getProto().hashCode();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == null) {
+ return false;
+ }
+ if (other.getClass().isAssignableFrom(this.getClass())) {
+ return this.getProto().equals(this.getClass().cast(other).getProto());
+ }
+ return false;
+ }
+
+ @Override
+ public String toString() {
+ return TextFormat.shortDebugString(getProto());
+ }
+
+ @Override
+ public ReservationId getReservationId() {
+ ReservationHomeSubClusterProtoOrBuilder p = viaProto ? proto : builder;
+ if (!p.hasReservationId()) {
+ return null;
+ }
+ this.reservationId = convertFromProtoFormat(p.getReservationId());
+ return reservationId;
+ }
+
+ @Override
+ public void setReservationId(ReservationId reservationId) {
+ maybeInitBuilder();
+ if (reservationId == null) {
+ builder.clearReservationId();
+ return;
+ }
+ this.reservationId = reservationId;
+ }
+
+ @Override
+ public SubClusterId getHomeSubCluster() {
+ ReservationHomeSubClusterProtoOrBuilder p = viaProto ? proto : builder;
+ if (this.homeSubCluster != null) {
+ return this.homeSubCluster;
+ }
+ if (!p.hasHomeSubCluster()) {
+ return null;
+ }
+ this.homeSubCluster = convertFromProtoFormat(p.getHomeSubCluster());
+ return this.homeSubCluster;
+ }
+
+ @Override
+ public void setHomeSubCluster(SubClusterId homeSubCluster) {
+ maybeInitBuilder();
+ if (homeSubCluster == null) {
+ builder.clearHomeSubCluster();
+ }
+ this.homeSubCluster = homeSubCluster;
Review Comment:
Don't hide the field
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/ReservationHomeSubClusterPBImpl.java:
##########
@@ -0,0 +1,167 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.yarn.server.federation.store.records.impl.pb;
+
+import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.yarn.api.records.ReservationId;
+import org.apache.hadoop.yarn.api.records.impl.pb.ReservationIdPBImpl;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProto;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.ReservationHomeSubClusterProtoOrBuilder;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.SubClusterIdProto;
+import org.apache.hadoop.yarn.proto.YarnProtos.ReservationIdProto;
+import
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
+import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
+
+import org.apache.hadoop.thirdparty.protobuf.TextFormat;
+
+/**
+ * Protocol buffer based implementation of {@link ReservationHomeSubCluster}.
+ */
+@Private
+@Unstable
+public class ReservationHomeSubClusterPBImpl extends ReservationHomeSubCluster
{
+
+ private ReservationHomeSubClusterProto proto =
+ ReservationHomeSubClusterProto.getDefaultInstance();
+ private ReservationHomeSubClusterProto.Builder builder = null;
+ private boolean viaProto = false;
+
+ private ReservationId reservationId = null;
+ private SubClusterId homeSubCluster = null;
+
+ public ReservationHomeSubClusterPBImpl() {
+ builder = ReservationHomeSubClusterProto.newBuilder();
+ }
+
+ public ReservationHomeSubClusterPBImpl(ReservationHomeSubClusterProto proto)
{
+ this.proto = proto;
+ viaProto = true;
+ }
+
+ public ReservationHomeSubClusterProto getProto() {
+ mergeLocalToProto();
+ proto = viaProto ? proto : builder.build();
+ viaProto = true;
+ return proto;
+ }
+
+ private void mergeLocalToProto() {
+ if (viaProto) {
+ maybeInitBuilder();
+ }
+ mergeLocalToBuilder();
+ proto = builder.build();
+ viaProto = true;
+ }
+
+ private void maybeInitBuilder() {
+ if (viaProto || builder == null) {
+ builder = ReservationHomeSubClusterProto.newBuilder(proto);
+ }
+ viaProto = false;
+ }
+
+ private void mergeLocalToBuilder() {
+ if (this.reservationId != null) {
+ builder.setReservationId(convertToProtoFormat(this.reservationId));
+ }
+ if (this.homeSubCluster != null) {
+ builder.setHomeSubCluster(convertToProtoFormat(this.homeSubCluster));
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return getProto().hashCode();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == null) {
+ return false;
+ }
+ if (other.getClass().isAssignableFrom(this.getClass())) {
+ return this.getProto().equals(this.getClass().cast(other).getProto());
+ }
+ return false;
+ }
+
+ @Override
+ public String toString() {
+ return TextFormat.shortDebugString(getProto());
+ }
+
+ @Override
+ public ReservationId getReservationId() {
+ ReservationHomeSubClusterProtoOrBuilder p = viaProto ? proto : builder;
+ if (!p.hasReservationId()) {
+ return null;
+ }
+ this.reservationId = convertFromProtoFormat(p.getReservationId());
+ return reservationId;
+ }
+
+ @Override
+ public void setReservationId(ReservationId reservationId) {
+ maybeInitBuilder();
+ if (reservationId == null) {
Review Comment:
Don't hide the field: resId as param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
