slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r942539715
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java: ########## @@ -312,4 +324,45 @@ public Version loadVersion() { return null; } + @Override + public AddReservationHomeSubClusterResponse addReservationHomeSubCluster( + AddReservationHomeSubClusterRequest request) throws YarnException { + FederationReservationHomeSubClusterStoreInputValidator.validate(request); + ReservationId reservationId = + request.getReservationHomeSubCluster().getReservationId(); + if (!reservations.containsKey(reservationId)) { + reservations.put(reservationId, + request.getReservationHomeSubCluster().getHomeSubCluster()); + } + return AddReservationHomeSubClusterResponse.newInstance(reservations.get(reservationId)); + } + + @Override + public GetReservationHomeSubClusterResponse getReservationHomeSubCluster( + GetReservationHomeSubClusterRequest request) throws YarnException { + FederationReservationHomeSubClusterStoreInputValidator.validate(request); + ReservationId reservationId = request.getReservationId(); + if (!reservations.containsKey(reservationId)) { + throw new YarnException("Reservation " + reservationId + " does not exist"); + } + SubClusterId subClusterId = reservations.get(reservationId); + return GetReservationHomeSubClusterResponse.newInstance( + ReservationHomeSubCluster.newInstance(reservationId, subClusterId)); + } + + @Override + public GetReservationsHomeSubClusterResponse getReservationsHomeSubCluster( + GetReservationsHomeSubClusterRequest request) throws YarnException { + List<ReservationHomeSubCluster> result = new ArrayList<>(); + + for (Entry<ReservationId, SubClusterId> entry : reservations.entrySet()) { + ReservationId key = entry.getKey(); + SubClusterId value = entry.getValue(); + ReservationHomeSubCluster homeSubCluster = Review Comment: I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org