dingshun3016 commented on PR #5170:
URL: https://github.com/apache/hadoop/pull/5170#issuecomment-1333269882

   > @dingshun3016 This seems to only happen when invoke addBlockPool() and 
CachingGetSpaceUsed#used < 0, so why not handle it for example like forbid 
refresh() when ReplicaCachingGetSpaceUsed#init() at first time ?
   
   @MingXiangLi  thanks reply
   
   forbid refresh() when ReplicaCachingGetSpaceUsed #init() at first time,it 
will cause the value of dfsUsage to be 0 until the next time refresh(). 
   
    if remove the BLOCK_POOl level write lock in the 
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl#addBlockPool(String
 bpid, Configuration conf) method, what will be the impact ?
   
   do you have any other suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to