virajjasani commented on code in PR #5294: URL: https://github.com/apache/hadoop/pull/5294#discussion_r1071510487
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java: ########## @@ -736,19 +733,17 @@ public Object run() throws IOException, InterruptedException { + UserGroupInformation.getLoginUser().getUserName() + " to " + remoteId; LOG.warn(msg, ex); - throw (IOException) new IOException(msg).initCause(ex); + throw new IOException(msg, ex); Review Comment: Destination address host:port would be included with this exception. However, yes `NetUtils.wrapException` is excellent utility and worth using here as it also covers wider variety of exceptions and updates the error msg accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org