steveloughran commented on code in PR #5294:
URL: https://github.com/apache/hadoop/pull/5294#discussion_r1072694913
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -733,7 +733,11 @@ public Object run() throws IOException,
InterruptedException {
+ UserGroupInformation.getLoginUser().getUserName() + " to "
+ remoteId;
LOG.warn(msg, ex);
- throw new IOException(msg, ex);
+ throw NetUtils.wrapException(remoteId.getAddress().getHostName(),
+ remoteId.getAddress().getPort(),
+ NetUtils.getHostname(),
+ 0,
+ new IOException(msg, ex));
Review Comment:
+1 for the change.
ex is only ever an IOException; we should preserve it so that the type
doesn't get lost in the chain.
* change the signature of the method to be `IOException ex` and then pass it
into wrap exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
