[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

[via GitHub]

p-szucs commented on code in PR #5320:
URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087785053


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java:
##########
@@ -508,29 +521,29 @@ public void testReservationSystemNotSupported() {
   }
 
   private void assertNoValueForQueues(Set<String> queues, String postfix,
-      Configuration config) {
+      CapacitySchedulerConfiguration capacitySchedulerConfig) {
     for (String queue : queues) {
       String key = PREFIX + queue + postfix;
       assertNull("Key " + key + " has value, but it should be null",
-          config.get(key));
+          capacitySchedulerConfig.get(key));
     }
   }
 
   private void assertValueForQueues(Set<String> queues, String postfix,
-      Configuration config, String expectedValue) {
+      CapacitySchedulerConfiguration capacitySchedulerConfig, String 
expectedValue) {
     for (String queue : queues) {
       String key = PREFIX + queue + postfix;
       assertEquals("Key " + key + " has different value",
-          expectedValue, config.get(key));
+          expectedValue, capacitySchedulerConfig.get(key));

Review Comment:
   The same applies here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org