p-szucs commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1404951874
I added some comments where I saw further possibilities for using the convenience get methods beside the fixed ones. I also saw that there are some config settings in the FsQueueConverter class where the CapacitySchedulerConfiguration’s setter methods could be used too, so that way we would have only one place for setting these values. For example here we can use the CapacitySchedulerConfiguration’s setMaximumCapacity() method: https://github.com/apache/hadoop/blob/a38eb1f19318e3dd34d9312afe1096db46652f49/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java#L167 What are your thoughts on that @brumi1024, @susheel-gupta? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
