slfan1989 commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122488897
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -419,31 +427,32 @@ public synchronized void addPersistedDelegationToken(
}
}
- /**
- * Update the current master key
- * This is called once by startThreads before tokenRemoverThread is created,
+ /**
+ * Update the current master key
+ * This is called once by startThreads before tokenRemoverThread is created,
* and only by tokenRemoverThread afterwards.
*/
- private void updateCurrentKey() throws IOException {
+ protected void updateCurrentKey() throws IOException {
LOG.info("Updating the current master key for generating delegation
tokens");
/* Create a new currentKey with an estimated expiry date. */
int newCurrentId;
synchronized (this) {
- newCurrentId = incrementCurrentKeyId();
+ newCurrentId = generateNewKeyId();
Review Comment:
Why should we change the method name？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
