krishan1390 commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122614703
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -531,9 +557,9 @@ protected DelegationTokenInformation checkToken(TokenIdent
identifier)
}
return info;
}
-
+
@Override
- public synchronized byte[] retrievePassword(TokenIdent identifier)
+ public byte[] retrievePassword(TokenIdent identifier)
Review Comment:
it is not required because currentTokens is a concurrenthashmap so satisfies
the happens before memory visibility requirements for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
