simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204730561
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##########
@@ -153,7 +157,7 @@ public void proxyOpComplete(boolean success, String nsId,
if (success) {
long proxyTime = getProxyTime();
if (proxyTime >= 0) {
- if (metrics != null) {
+ if (metrics != null && !nsId.equals(CONCURRENT)) {
metrics.addProxyTime(proxyTime, state);
}
if (nameserviceRPCMetricsMap != null &&
Review Comment:
In the unit tests, can you also check that the proxy time for the
"concurrent" namespace is being created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
