hfutatzhanghb commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204928219
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##########
@@ -153,7 +157,7 @@ public void proxyOpComplete(boolean success, String nsId,
if (success) {
long proxyTime = getProxyTime();
if (proxyTime >= 0) {
- if (metrics != null) {
+ if (metrics != null && !nsId.equals(CONCURRENT)) {
Review Comment:
>
@simbadzina Sir, thanks for your suggestions so much. I have fixed it.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/metrics/TestNameserviceRPCMetrics.java:
##########
@@ -134,5 +136,26 @@ public void testProxyOp() throws IOException {
getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns1"));
}
+ @Test
+ public void testProxyOpCompleteConcurrent() throws IOException {
+
+ long ns0ProxyOpBefore = getLongCounter("ProxyOp",
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns0"));
+ long ns1ProxyOpBefore = getLongCounter("ProxyOp",
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns1"));
+ assertCounter("ProxyOp", 0L,
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "concurrent"));
+ // RPC which uses invokeConcurrent.
+ router.getRpcServer().setBalancerBandwidth(1048576L);
Review Comment:
Sir, thanks for your reviewing. Have fixed it.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/metrics/TestNameserviceRPCMetrics.java:
##########
@@ -134,5 +136,26 @@ public void testProxyOp() throws IOException {
getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns1"));
}
+ @Test
+ public void testProxyOpCompleteConcurrent() throws IOException {
+
+ long ns0ProxyOpBefore = getLongCounter("ProxyOp",
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns0"));
+ long ns1ProxyOpBefore = getLongCounter("ProxyOp",
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns1"));
+ assertCounter("ProxyOp", 0L,
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "concurrent"));
+ // RPC which uses invokeConcurrent.
+ router.getRpcServer().setBalancerBandwidth(1048576L);
+
+ assertCounter("ProxyOp", ns0ProxyOpBefore + 1,
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns0"));
+ assertCounter("ProxyOp", ns1ProxyOpBefore + 1,
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + "ns1"));
+ assertCounter("ProxyOp", 1L,
+ getMetrics(NAMESERVICE_RPC_METRICS_PREFIX + CONCURRENT));
+
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
