xinglin commented on code in PR #5700: URL: https://github.com/apache/hadoop/pull/5700#discussion_r1212423619
########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java: ########## @@ -213,6 +241,13 @@ public ObserverReadProxyProvider( observerProbeRetryPeriodMs = conf.getTimeDuration( OBSERVER_PROBE_RETRY_PERIOD_KEY, OBSERVER_PROBE_RETRY_PERIOD_DEFAULT, TimeUnit.MILLISECONDS); + namenodeHAStateProbeTimeoutSec = conf.getTimeDuration( + NAMENODE_HA_STATE_PROBE_TIMEOUT, + NAMENODE_HA_STATE_PROBE_TIMEOUT_DEFAULT, TimeUnit.SECONDS); + // Disallow negative values for namenodeHAStateProbeTimeoutSec + if (namenodeHAStateProbeTimeoutSec < 0) { + namenodeHAStateProbeTimeoutSec = NAMENODE_HA_STATE_PROBE_TIMEOUT_DEFAULT; + } Review Comment: It is unfortunate that Future in Java uses two separate APIs when waiting to get the result: get(timeout) and get(), which waits without a timeout. Changed the code with an if case, to support the case where namenodeHAStateProbeTimeoutSec is less or equal to 0 (no timeout). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org