simbadzina commented on code in PR #5700:
URL: https://github.com/apache/hadoop/pull/5700#discussion_r1213790073
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java:
##########
@@ -434,6 +438,41 @@ public void
testExecutionExceptionGetHAServiceStateWithTimeout() throws Exceptio
verify(logger).debug(eq("Exception in NN probe task for {}: {}"),
eq(null), eq(e));
}
+ /**
+ * Test default (no timeout) getHAServiceState when we have a slow NN.
Review Comment:
`no timeout` should be `long timeout`.
I got confused and thought you'd now made the default having no timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
