[ 
https://issues.apache.org/jira/browse/HADOOP-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233410#comment-13233410
 ] 

Daryn Sharp commented on HADOOP-8179:
-------------------------------------

Regarding no test, I was able to test locally by: starting a mini-cluster, 
creating a file with insufficient privs for different user (non-superuser) to 
access, then tried to access the file with that different user.  I saw the NPE 
before, but not after, the patch.
                
> risk of NPE in CopyCommands processArguments()
> ----------------------------------------------
>
>                 Key: HADOOP-8179
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8179
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.24.0, 0.23.2
>            Reporter: Steve Loughran
>            Assignee: Daryn Sharp
>            Priority: Minor
>         Attachments: HADOOP-8179.patch, HADOOP-8179.patch
>
>
> My IDE is warning me that the {{is.close()}} method will NPE if the {{is = 
> src.fs.open(src.path);}} call raises an exception, which could happen if the 
> source path could not be opened. There should be an if (is!=null) wrapper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to