[ https://issues.apache.org/jira/browse/HADOOP-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233444#comment-13233444 ]
Daryn Sharp commented on HADOOP-8179: ------------------------------------- Good eye, but I'm actually fixing the close issue on a separate jira. Just an aside, using IOUtils to close the output stream is inappropriate because it will mask exceptions that may be related to finalizing the block. > risk of NPE in CopyCommands processArguments() > ---------------------------------------------- > > Key: HADOOP-8179 > URL: https://issues.apache.org/jira/browse/HADOOP-8179 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.24.0, 0.23.2 > Reporter: Steve Loughran > Assignee: Daryn Sharp > Priority: Minor > Attachments: HADOOP-8179.patch, HADOOP-8179.patch > > > My IDE is warning me that the {{is.close()}} method will NPE if the {{is = > src.fs.open(src.path);}} call raises an exception, which could happen if the > source path could not be opened. There should be an if (is!=null) wrapper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira