virajjasani commented on code in PR #6180: URL: https://github.com/apache/hadoop/pull/6180#discussion_r1363203939
########## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ########## @@ -1596,14 +1596,15 @@ <property> <name>fs.s3a.connection.establish.timeout</name> - <value>5000</value> - <description>Socket connection setup timeout in milliseconds.</description> + <value>5s</value> + <description>Socket connection setup timeout in milliseconds; this will be retried + more than once.</description> </property> <property> <name>fs.s3a.connection.timeout</name> - <value>200000</value> - <description>Socket connection timeout in milliseconds.</description> + <value>200s</value> + <description>Socket connection timeout.</description> Review Comment: For both of them, is it valuable to mention in the description that milliseconds is the default unit unless user specifies any other unit explicitly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
