virajjasani commented on code in PR #6180:
URL: https://github.com/apache/hadoop/pull/6180#discussion_r1363235836
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java:
##########
@@ -378,17 +388,39 @@ private static void initSigner(Configuration conf,
*/
private static void initRequestTimeout(Configuration conf,
ClientOverrideConfiguration.Builder clientConfig) {
- long requestTimeoutMillis = conf.getTimeDuration(REQUEST_TIMEOUT,
- DEFAULT_REQUEST_TIMEOUT, TimeUnit.SECONDS, TimeUnit.MILLISECONDS);
+ final Duration requestTimeoutMillis = getDuration(conf, REQUEST_TIMEOUT,
+ DEFAULT_REQUEST_TIMEOUT, TimeUnit.SECONDS);
- if (requestTimeoutMillis > Integer.MAX_VALUE) {
- LOG.debug("Request timeout is too high({} ms). Setting to {} ms instead",
- requestTimeoutMillis, Integer.MAX_VALUE);
- requestTimeoutMillis = Integer.MAX_VALUE;
+ if (requestTimeoutMillis.toMillis() > 0) {
+ clientConfig.apiCallAttemptTimeout(requestTimeoutMillis);
}
+ }
- if(requestTimeoutMillis > 0) {
-
clientConfig.apiCallAttemptTimeout(Duration.ofMillis(requestTimeoutMillis));
+ /**
+ * Get duration. This may be negative; callers must check.
+ * If the config option is greater than {@code Integer.MAX_VALUE}
milliseconds,
+ * it is set to that max.
+ * Logs the value for diagnostics.
+ * @param conf config
+ * @param name option name
+ * @param defVal default value
+ * @param defaultUnit unit of default value
+ * @return duration. may be negative.
+ */
+ private static Duration getDuration(final Configuration conf,
Review Comment:
nit: `getDurationInMillis` or `getDurationWithMillis` might be better?
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java:
##########
@@ -378,17 +388,39 @@ private static void initSigner(Configuration conf,
*/
private static void initRequestTimeout(Configuration conf,
ClientOverrideConfiguration.Builder clientConfig) {
- long requestTimeoutMillis = conf.getTimeDuration(REQUEST_TIMEOUT,
- DEFAULT_REQUEST_TIMEOUT, TimeUnit.SECONDS, TimeUnit.MILLISECONDS);
+ final Duration requestTimeoutMillis = getDuration(conf, REQUEST_TIMEOUT,
+ DEFAULT_REQUEST_TIMEOUT, TimeUnit.SECONDS);
- if (requestTimeoutMillis > Integer.MAX_VALUE) {
- LOG.debug("Request timeout is too high({} ms). Setting to {} ms instead",
- requestTimeoutMillis, Integer.MAX_VALUE);
- requestTimeoutMillis = Integer.MAX_VALUE;
+ if (requestTimeoutMillis.toMillis() > 0) {
+ clientConfig.apiCallAttemptTimeout(requestTimeoutMillis);
}
+ }
- if(requestTimeoutMillis > 0) {
-
clientConfig.apiCallAttemptTimeout(Duration.ofMillis(requestTimeoutMillis));
+ /**
+ * Get duration. This may be negative; callers must check.
+ * If the config option is greater than {@code Integer.MAX_VALUE}
milliseconds,
+ * it is set to that max.
+ * Logs the value for diagnostics.
+ * @param conf config
+ * @param name option name
+ * @param defVal default value
+ * @param defaultUnit unit of default value
+ * @return duration. may be negative.
Review Comment:
nit: `Get duration` -> `Get duration object representing value in
milliseconds`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
