[
https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237317#comment-13237317
]
Suresh Srinivas commented on HADOOP-8202:
-----------------------------------------
bq. HADOOP-7607
I take what you are saying - since I do not want to waste time on this.
bq. Sure, they're definitely just nits, but it's not like they're difficult to
address. It almost certainly would take less time to address these comments
than it does to argue about them.
In the comments, I post this kind of comments as optional - as a suggestion. If
the contributor likes it/wants to address it, then it is up to him. Perhaps,
adding optional/suggestion for such comments would be good, instead of cycles
of nits and time wasted on addressing them. We can make better use of time.
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
> Key: HADOOP-8202
> URL: https://issues.apache.org/jira/browse/HADOOP-8202
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Priority: Minor
> Attachments: HADOOP-8202-1.patch, HADOOP-8202-2.patch,
> HADOOP-8202.patch, HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being
> closed. Talked with Suresh and he observed that most of the protocols do not
> implement ProtocolTranslator and hence the logic in stopproxy() does not
> work. Instead, since all of them are closeable, Suresh suggested that
> closeable property should be used at close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
