[ 
https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238088#comment-13238088
 ] 

Aaron T. Myers commented on HADOOP-8202:
----------------------------------------

Hey Hari, thanks for updating the patch to fix TestHealthMonitor.

bq. There were test failures. However, it does not seem to be related to 
stopproxy() changes. I will file jiras on the test failures.

Can you list here which tests failed? Can you comment on Todd's comment that 
he's surprised many HDFS tests didn't fail? Perhaps it's because in most tests 
where we mock out a protocol object, we never try to close that protocol 
object. Just a guess.
                
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
>                 Key: HADOOP-8202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8202
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>            Priority: Minor
>         Attachments: HADOOP-8202-1.patch, HADOOP-8202-2.patch, 
> HADOOP-8202-3.patch, HADOOP-8202.patch, HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being 
> closed. Talked with Suresh and he observed that most of the protocols do not 
> implement ProtocolTranslator and hence the logic in stopproxy() does not 
> work. Instead, since all of them are closeable, Suresh suggested that 
> closeable property should be used at close.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to