huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1411726415
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ########## @@ -46,11 +46,6 @@ public class SlowPeerDisabledTracker extends SlowPeerTracker { public SlowPeerDisabledTracker(Configuration conf, Timer timer) { super(conf, timer); - final boolean dataNodePeerStatsEnabledVal = - conf.getBoolean(DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_KEY, - DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_DEFAULT); - Preconditions.checkArgument(!dataNodePeerStatsEnabledVal, - "SlowPeerDisabledTracker should only be used for disabled slow peer stats."); Review Comment: The conf obtained here is the one currently running in the system, so delete these verification logic. NameNode#reconfigureSlowNodesParameters => datanodeManager.initSlowPeerTracker(getConf(), timer, peerStatsEnabled) => getConf() => dataNodePeerStatsEnabledVal==true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org