[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239178#comment-13239178 ]
Hadoop QA commented on HADOOP-8220: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520062/hadoop-8220.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.ha.TestFailoverController org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/789//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/789//console This message is automatically generated. > ZKFailoverController doesn't handle failure to become active correctly > ---------------------------------------------------------------------- > > Key: HADOOP-8220 > URL: https://issues.apache.org/jira/browse/HADOOP-8220 > Project: Hadoop Common > Issue Type: Bug > Components: ha > Affects Versions: 0.23.3, 0.24.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Critical > Attachments: hadoop-8220.txt > > > The ZKFC doesn't properly handle the case where the monitored service fails > to become active. Currently, it catches the exception and logs a warning, but > then continues on, after calling quitElection(). This causes a NPE when it > later tries to use the same zkClient instance while handling that same > request. There is a test case, but the test case doesn't ensure that the node > that had the failure is later able to recover properly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira