[
https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239301#comment-13239301
]
Bikas Saha commented on HADOOP-8220:
------------------------------------
Test missing for changes in ActiveStandbyElector.
Do you really want to commit the logs added to ActiveStandbyTestUtil?
bq.The ZKFC doesn't properly handle the case where the monitored service fails
to become active. Currently, it catches the exception and logs a warning, but
then continues on, after calling quitElection(). This causes a NPE when it
later tries to use the same zkClient instance while handling that same request.
There is a test case, but the test case doesn't ensure that the node that had
the failure is later able to recover properly.
How does NPE occur when the elector makes sure the client is recreated upon
rejoining the election? Which zkClient are you talking about?
What is the purpose of adding the sleep? Could you please elaborate?
> ZKFailoverController doesn't handle failure to become active correctly
> ----------------------------------------------------------------------
>
> Key: HADOOP-8220
> URL: https://issues.apache.org/jira/browse/HADOOP-8220
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8220.txt
>
>
> The ZKFC doesn't properly handle the case where the monitored service fails
> to become active. Currently, it catches the exception and logs a warning, but
> then continues on, after calling quitElection(). This causes a NPE when it
> later tries to use the same zkClient instance while handling that same
> request. There is a test case, but the test case doesn't ensure that the node
> that had the failure is later able to recover properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
