[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839119#comment-17839119 ]
ASF GitHub Bot commented on HADOOP-19152: ----------------------------------------- szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2067272199 Let me clarify in more details: - Current code without any changes: - Force everyone to add the `bcprov-jdk18on` security provider - Current PR (remove `bcprov-jdk18on` dependency and remove the hardcoded provider but not using reflection) - Users/downstream project can still use `bcprov-jdk18on` by - (1) adding `bcprov-jdk18on` provider statically in the java.security file, or added dynamically by calling the java.security.Security.addProvider(..) method; and - (2) making `bcprov-jdk18on` jar in the class path . - Alternative PR (remove `bcprov-jdk18on` dependency and change the hardcoded provider using reflection) - Users/downstream project can still use `bcprov-jdk18on` by only (2) above, i.e. (1) is not needed. > Do not hard code security providers. > ------------------------------------ > > Key: HADOOP-19152 > URL: https://issues.apache.org/jira/browse/HADOOP-19152 > Project: Hadoop Common > Issue Type: Improvement > Components: security > Reporter: Tsz-wo Sze > Assignee: Tsz-wo Sze > Priority: Major > Labels: pull-request-available > > In order to support different security providers in different clusters, we > should not hard code a provider in our code. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org