[ 
https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840144#comment-17840144
 ] 

ASF GitHub Bot commented on HADOOP-19152:
-----------------------------------------

szetszwo commented on code in PR #6739:
URL: https://github.com/apache/hadoop/pull/6739#discussion_r1576476989


##########
hadoop-common-project/hadoop-common/src/main/resources/core-default.xml:
##########
@@ -3625,7 +3625,19 @@ The switch to turn S3A auditing on or off.
     The JCE provider name used in CryptoCodec.
     If this value is set, the corresponding provider must be added to the 
provider list.
     The provider may be added statically in the java.security file, or
-    added dynamically by calling the java.security.Security.addProvider(..) 
method.
+    dynamically by calling the java.security.Security.addProvider(..) method, 
or
+    automatically (only for org.bouncycastle.jce.provider.BouncyCastleProvider)
+    by setting "hadoop.security.crypto.jce.provider.add" to true
+  </description>
+</property>
+
+<property>
+  <name>hadoop.security.crypto.jce.provider.add</name>

Review Comment:
   Let's change it to `auto-add`.





> Do not hard code security providers.
> ------------------------------------
>
>                 Key: HADOOP-19152
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19152
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>              Labels: pull-request-available
>
> In order to support different security providers in different clusters, we 
> should not hard code a provider in our code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to