hfutatzhanghb commented on code in PR #6634:
URL: https://github.com/apache/hadoop/pull/6634#discussion_r1604540074
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3654,14 +3654,15 @@ void setQuota(String src, long nsQuota, long ssQuota,
StorageType type)
checkSuperuserPrivilege(operationName, src);
}
try {
- writeLock();
+ // Need to compute the curren space usage
+ writeLock(FSNamesystemLockMode.GLOBAL);
Review Comment:
@ZanderXu Sir. I can not understand why we use GLOBAL lock here. Seems that
setQuota does not involve blocks opertions. Also in `getQuotaUsage`
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3654,14 +3654,15 @@ void setQuota(String src, long nsQuota, long ssQuota,
StorageType type)
checkSuperuserPrivilege(operationName, src);
}
try {
- writeLock();
+ // Need to compute the curren space usage
Review Comment:
typo for current.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
