ZanderXu commented on code in PR #6634:
URL: https://github.com/apache/hadoop/pull/6634#discussion_r1605789539
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3654,14 +3654,15 @@ void setQuota(String src, long nsQuota, long ssQuota,
StorageType type)
checkSuperuserPrivilege(operationName, src);
}
try {
- writeLock();
+ // Need to compute the curren space usage
+ writeLock(FSNamesystemLockMode.GLOBAL);
Review Comment:
`computeQuotaUsage` needs to rely on block state to get
storagespaceConsumed, so the GLOBAL lock is used here. After HDFS-17497 is
merged, this global lock can be replaced by the fs lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
