[
https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853076#comment-17853076
]
ASF GitHub Bot commented on HADOOP-18325:
-----------------------------------------
saxenapranav commented on code in PR #6847:
URL: https://github.com/apache/hadoop/pull/6847#discussion_r1630837840
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -202,21 +202,25 @@ private AbfsClient(final URL baseUrl,
this.isMetricCollectionStopped = new AtomicBoolean(false);
this.metricAnalysisPeriod = abfsConfiguration.getMetricAnalysisTimeout();
this.metricIdlePeriod = abfsConfiguration.getMetricIdleTimeout();
- if (!metricFormat.toString().equals("")) {
- isMetricCollectionEnabled = true;
- abfsCounters.initializeMetrics(metricFormat);
+ if (!metricFormat.toString().equals(EMPTY_STRING)) {
String metricAccountName = abfsConfiguration.getMetricAccount();
- int dotIndex = metricAccountName.indexOf(AbfsHttpConstants.DOT);
- if (dotIndex <= 0) {
- throw new InvalidUriException(
- metricAccountName + " - account name is not fully qualified.");
- }
String metricAccountKey = abfsConfiguration.getMetricAccountKey();
- try {
- metricSharedkeyCredentials = new
SharedKeyCredentials(metricAccountName.substring(0, dotIndex),
- metricAccountKey);
- } catch (IllegalArgumentException e) {
- throw new IOException("Exception while initializing metric credentials
" + e);
+ if (!metricAccountName.equals(EMPTY_STRING) &&
!metricAccountKey.equals(EMPTY_STRING)) {
Review Comment:
would be better if we can use StringUtils.isNotEmpty(), as it would null and
empty checks.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -202,21 +202,25 @@ private AbfsClient(final URL baseUrl,
this.isMetricCollectionStopped = new AtomicBoolean(false);
this.metricAnalysisPeriod = abfsConfiguration.getMetricAnalysisTimeout();
this.metricIdlePeriod = abfsConfiguration.getMetricIdleTimeout();
- if (!metricFormat.toString().equals("")) {
- isMetricCollectionEnabled = true;
- abfsCounters.initializeMetrics(metricFormat);
+ if (!metricFormat.toString().equals(EMPTY_STRING)) {
String metricAccountName = abfsConfiguration.getMetricAccount();
- int dotIndex = metricAccountName.indexOf(AbfsHttpConstants.DOT);
- if (dotIndex <= 0) {
- throw new InvalidUriException(
- metricAccountName + " - account name is not fully qualified.");
- }
String metricAccountKey = abfsConfiguration.getMetricAccountKey();
- try {
- metricSharedkeyCredentials = new
SharedKeyCredentials(metricAccountName.substring(0, dotIndex),
- metricAccountKey);
- } catch (IllegalArgumentException e) {
- throw new IOException("Exception while initializing metric credentials
" + e);
+ if (!metricAccountName.equals(EMPTY_STRING) &&
!metricAccountKey.equals(EMPTY_STRING)) {
+ isMetricCollectionEnabled = true;
+ abfsCounters.initializeMetrics(metricFormat);
+ int dotIndex = metricAccountName.indexOf(AbfsHttpConstants.DOT);
+ if (dotIndex <= 0) {
+ throw new InvalidUriException(
+ metricAccountName + " - account name is not fully qualified.");
+ }
+ try {
+ metricSharedkeyCredentials = new SharedKeyCredentials(
+ metricAccountName.substring(0, dotIndex),
+ metricAccountKey);
+ } catch (IllegalArgumentException e) {
+ throw new IOException(
+ "Exception while initializing metric credentials " + e);
Review Comment:
throw new IOException(message, e) would be better as the consumer of this
exception can get the inner-exception.
> ABFS: Add correlated metric support for ABFS operations
> -------------------------------------------------------
>
> Key: HADOOP-18325
> URL: https://issues.apache.org/jira/browse/HADOOP-18325
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.3
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Add metrics related to a particular job, specific to number of total
> requests, retried requests, retry count and others
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
