[
https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855180#comment-17855180
]
ASF GitHub Bot commented on HADOOP-18325:
-----------------------------------------
rakeshadr commented on code in PR #6847:
URL: https://github.com/apache/hadoop/pull/6847#discussion_r1640744932
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java:
##########
@@ -39,6 +44,19 @@ public class TestAbfsRestOperation extends
public TestAbfsRestOperation() throws Exception {
}
+ private void checkPrerequisites() throws Exception {
+ checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_NAME);
+ checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_KEY);
+ checkIfConfigIsSet(FS_AZURE_METRIC_URI);
+ }
+
+ private void checkIfConfigIsSet(String configKey){
+ AbfsConfiguration conf = getConfiguration();
+ String value = conf.get(configKey);
+ Assume.assumeTrue(configKey + " config is mandatory for the test to run",
Review Comment:
@anmolanmol1234 Should this be Assert.assertTrue instead of
Assume.assumeTrue ?
Assume will skip the test in case of failure.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsReadFooterMetrics.java:
##########
@@ -47,6 +52,20 @@
public class ITestAbfsReadFooterMetrics extends AbstractAbfsScaleTest {
public ITestAbfsReadFooterMetrics() throws Exception {
+ checkPrerequisites();
+ }
+
+ private void checkPrerequisites(){
+ checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_NAME);
+ checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_KEY);
+ checkIfConfigIsSet(FS_AZURE_METRIC_URI);
+ }
+
+ private void checkIfConfigIsSet(String configKey){
+ AbfsConfiguration conf = getConfiguration();
+ String value = conf.get(configKey);
+ Assume.assumeTrue(configKey + " config is mandatory for the test to run",
Review Comment:
@anmolanmol1234 Should this be Assert.assertTrue instead of
Assume.assumeTrue ?
Assume will skip the test in case of failure.
> ABFS: Add correlated metric support for ABFS operations
> -------------------------------------------------------
>
> Key: HADOOP-18325
> URL: https://issues.apache.org/jira/browse/HADOOP-18325
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.3
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Add metrics related to a particular job, specific to number of total
> requests, retried requests, retry count and others
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
