[
https://issues.apache.org/jira/browse/HADOOP-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264375#comment-13264375
]
Todd Lipcon commented on HADOOP-8323:
-------------------------------------
- in the Javadoc use HTML like <em>Note</em> instead of {{*Note*}} (hopefully
JIRA doesn't mangle my comment here.. saying to use the 'em' HTML tag)
- for the code example, use the 'code' html tag in the javadoc instead of
double quotes
- for the assertions, I think it's clearer for the provided string to state the
expected behavior instead of the error behavior. for example: "String should
empty after clear()" instead of "String isn't empty after clear"
> Revert HADOOP-7940 and improve javadocs and test for Text.clear()
> -----------------------------------------------------------------
>
> Key: HADOOP-8323
> URL: https://issues.apache.org/jira/browse/HADOOP-8323
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Critical
> Labels: performance
> Attachments: HADOOP-8323.patch
>
>
> Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has
> caused a performance regression (for scenarios where Text is reused, popular
> in MR).
> The clear() works as intended, as the API also offers a current length API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
