[ https://issues.apache.org/jira/browse/HADOOP-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264523#comment-13264523 ]
Hadoop QA commented on HADOOP-8323: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525019/HADOOP-8323.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.io.TestSequenceFile +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/904//console This message is automatically generated. > Revert HADOOP-7940 and improve javadocs and test for Text.clear() > ----------------------------------------------------------------- > > Key: HADOOP-8323 > URL: https://issues.apache.org/jira/browse/HADOOP-8323 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 2.0.0 > Reporter: Harsh J > Assignee: Harsh J > Priority: Critical > Labels: performance > Attachments: HADOOP-8323.patch, HADOOP-8323.patch > > > Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has > caused a performance regression (for scenarios where Text is reused, popular > in MR). > The clear() works as intended, as the API also offers a current length API. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira