xyu commented on PR #7426: URL: https://github.com/apache/hadoop/pull/7426#issuecomment-2685734885
> How about add another single configure item about connection timeout here? Sure we can do that, what do you think about `hadoop.zk.curator-connection-timeout-ms` with a default value of `10000` to match the current `hadoop.zk.timeout-ms` default config? I was a bit hesitant to do this at first because I find it a little annoying that we have to expose a tuning for Curator into Hadoop configs but I'm not against that approach either. > Actually for zookeeper, the connection timeout is calculated by `sessionTimeout` rather than equal to `sessionTimeout`. Yeah I guess this is true, ZK will negotiate a timeout with the client based on it's allowed max/min range on the server and what the client requests. So I guess in theory someone could say set a 60s timeout for a default ZK install and end up getting capped at 40s (20 ticks * 2000ms per tick). That setting would effectively set Curator connection timeout to 60s on top of a ZK connection timeout of 40s. (Similar to how we currently default to 15s Curator connection timeout on top of a 10s timeout ZK connection.) I'm actually not sure what the failure scenario looks like for these Curator "connection timeout" being longer than the underlying connection. I see that Curator warns about it but I don't have an in depth understanding of what happens with Curator when configured this way. @Hexiaoqiao what do you think is the best way to resolve this? Should we just warn users in docs that Curator connection timeout needs to be lower than ZK session timeout and that the session timeout is negotiated? Something else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
