Hexiaoqiao commented on PR #7426: URL: https://github.com/apache/hadoop/pull/7426#issuecomment-2686742453
Thanks @xyu for your detailed comments. > what do you think about hadoop.zk.curator-connection-timeout-ms with a default value of 10000 to match the current hadoop.zk.timeout-ms default config. +1. > I was a bit hesitant to do this at first because I find it a little annoying that we have to expose a tuning for Curator into Hadoop configs. Strong +1 from my side. Now the config items is so many to confuse end user. I have no idea to improve that currently. Back to this PR, I think expose ZK/Curator config is proper based on the current status because we could not manage ZK/Curator logic in Hadoop community, so leave the choice to end user maybe one reasonable tradeoff. About the default value, I prefer change the default Hadoop ZK timeout from 10s to 15s and give `hadoop.zk.curator-connection-timeout-ms` with 10000ms by default. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
