[
https://issues.apache.org/jira/browse/HADOOP-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932273#comment-17932273
]
ASF GitHub Bot commented on HADOOP-19471:
-----------------------------------------
anmolanmol1234 commented on code in PR #7461:
URL: https://github.com/apache/hadoop/pull/7461#discussion_r1979209178
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -644,16 +658,20 @@ public int getInt(String key, int defaultValue) {
}
/**
- * Returns the account-specific password in string form if it exists, then
+ * Returns the container-specific password if it exists,
+ * else searches for the account-specific password, else finally
* looks for an account-agnostic value.
* @param key Account-agnostic configuration key
* @return value in String form if one exists, else null
* @throws IOException if parsing fails.
*/
public String getPasswordString(String key) throws IOException {
- char[] passchars = rawConfig.getPassword(accountConf(key));
- if (passchars == null) {
- passchars = rawConfig.getPassword(key);
+ char[] passchars = rawConfig.getPassword(containerConf(key));
+ if(passchars == null) {
+ passchars = rawConfig.getPassword(accountConf(key));
+ if(passchars == null){
+ passchars = rawConfig.getPassword(key);
+ }
Review Comment:
can be simplified as :- char[] passchars =
rawConfig.getPassword(containerConf(key)) != null ?
rawConfig.getPassword(containerConf(key)) :
rawConfig.getPassword(accountConf(key)) != null ?
rawConfig.getPassword(accountConf(key)) :
rawConfig.getPassword(key);
> ABFS: Support Fixed SAS token at container level
> -------------------------------------------------
>
> Key: HADOOP-19471
> URL: https://issues.apache.org/jira/browse/HADOOP-19471
> Project: Hadoop Common
> Issue Type: Task
> Affects Versions: 3.4.0, 3.4.1
> Reporter: Manika Joshi
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0, 3.4.2
>
>
> The ABFS driver currently lacks support for multiple SAS tokens for the same
> storage account across different containers.
> We are now introducing this support.
> To use fixed SAS token at container level the configuration to be used is:
> {quote}fs.azure.sas.fixed.token.<container-name>.<storage-account-name>
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
