[ 
https://issues.apache.org/jira/browse/HADOOP-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934242#comment-17934242
 ] 

ASF GitHub Bot commented on HADOOP-19471:
-----------------------------------------

manika137 commented on code in PR #7461:
URL: https://github.com/apache/hadoop/pull/7461#discussion_r1989442983


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChooseSAS.java:
##########
@@ -126,6 +147,43 @@ public void testBothProviderFixedTokenConfigured() throws 
Exception {
     }
   }
 
+  /**
+   * Helper method to get the Fixed SAS token value
+   */
+  private String getFixedSASToken(AbfsConfiguration config) throws Exception {
+    return config.getSASTokenProvider().getSASToken(this.getAccountName(), 
this.getFileSystemName(), getMethodName(),

Review Comment:
   Corrected



##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java:
##########
@@ -322,6 +322,10 @@ public static String accountProperty(String property, 
String account) {
     return property + "." + account;
   }
 
+  public static String containerProperty(String property, String fsName, 
String account) {
+    return property + "." + fsName + "." + account;

Review Comment:
   Taken





> ABFS:  Support Fixed SAS token at container level
> -------------------------------------------------
>
>                 Key: HADOOP-19471
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19471
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.0, 3.4.1
>            Reporter: Manika Joshi
>            Assignee: Manika Joshi
>            Priority: Major
>              Labels: pull-request-available
>
> The ABFS driver currently lacks support for multiple SAS tokens for the same 
> storage account across different containers.
> We are now introducing this support.
> To use fixed SAS token at container level the configuration to be used is:
> {quote}fs.azure.sas.fixed.token.<container-name>.<storage-account-name>
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to