[
https://issues.apache.org/jira/browse/HADOOP-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938893#comment-17938893
]
ASF GitHub Bot commented on HADOOP-19406:
-----------------------------------------
anmolanmol1234 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2016225630
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -813,12 +813,15 @@ destination, sourceEtag, isAtomicRenameKey(source),
tracingContext
if (blobRenameHandler.execute()) {
final AbfsUriQueryBuilder abfsUriQueryBuilder
= createDefaultUriQueryBuilder();
+ appendSASTokenToQuery(source, SASTokenProvider.RENAME_SOURCE_OPERATION,
+ abfsUriQueryBuilder);
final URL url = createRequestUrl(destination,
abfsUriQueryBuilder.toString());
final List<AbfsHttpHeader> requestHeaders = createDefaultHeaders();
final AbfsRestOperation successOp = getSuccessOp(
AbfsRestOperationType.RenamePath, HTTP_METHOD_PUT,
url, requestHeaders);
+ successOp.setMask();
Review Comment:
Why is this performed only in the rename case ? By default we mask for all
cases if auth type is SAS
> ABFS: [FNS Over Blob] Support User Delegation SAS for FNS Blob
> --------------------------------------------------------------
>
> Key: HADOOP-19406
> URL: https://issues.apache.org/jira/browse/HADOOP-19406
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> In ABFS Driver, user delegation SAS is currently only supported by
> hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR
> adds support for User Delegation SAS for non-HNS accounts over Blob endpoint
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
